PHP: Add a cwd argument to hotSwapPHPRuntime() #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support [Loopback Request](#1287), we need to decouple BasePHP from the request handler. This PR removes the implicit dependency from hotSwapPHPRuntime, where `requestHandler.documentRoot` was accessed, and replaces it with an explicit `cwd` argument. In the future, that argument will be removed and the PHP constructor will accept a class-level `cwd` property. ## Testing instructions Confirm the CI checks pass.
adamziel
force-pushed
the
decouple-rotating-php-runtime-from-request-handler
branch
from
c914845 to
8f62b90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support Loopback Request, we need to decouple BasePHP from the request handler. This PR removes the implicit dependency from hotSwapPHPRuntime, where
requestHandler.documentRootwas accessed, and replaces it with an explicitcwdargument. In the future, that argument will be removed and the PHP constructor will accept a class-levelcwdproperty.Testing instructions
Confirm the CI checks pass.