Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPRequestHandler: Add a generic PHP argument #1310

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

adamziel
Copy link
Collaborator

Before: PHPRequestHandler
After: PHPRequestHandler<PHP extends BasePHP>

This is a part of the Loopback request support

Testing instructions

Confirm the CI checks pass

Before: `PHPRequestHandler`
After: `PHPRequestHandler<PHP extends BasePHP>`

This is a part of the [Loopback request support](#1287)

 ## Testing instructions

Confirm the CI checks pass
@adamziel adamziel merged commit 3ec7c22 into remove-php-browser-2 Apr 23, 2024
5 checks passed
@adamziel adamziel deleted the php-request-handler-generic branch April 23, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant