Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Worker: fetch credentialless to play more nicely with server caches (#1311) #1311

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Service Worker: fetch credentialless to play more nicely with server caches (#1311) #1311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/php-wasm/web-service-worker/src/initialize-service-worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ async function defaultRequestHandler(event: FetchEvent) {
) {
const request = await cloneRequest(event.request, {
url,
// Omit credentials to avoid causing cache aborts due to presence of cookies
credentials: 'omit',
});
return fetch(request);
}
Expand Down
2 changes: 2 additions & 0 deletions packages/playground/remote/service-worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ initializeServiceWorker({
}
const request = await cloneRequest(event.request, {
url: resolvedUrl,
// Omit credentials to avoid causing cache aborts due to presence of cookies
credentials: 'omit',
});
return fetch(request).catch((e) => {
if (e?.name === 'TypeError') {
Expand Down
Loading