Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spawn handler: wrap the program call with try/catch, exit gracefully on error #1320

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Spawn handler: wrap the program call with try/catch, exit gracefully on error #1320

merged 1 commit into from
Apr 25, 2024

Conversation

adamziel
Copy link
Collaborator

What is this PR doing?

Prevents unhandled rejections when the spawned program crashes.

Testing Instructions

Confirm CI tests pass

@adamziel adamziel merged commit 3d15529 into trunk Apr 25, 2024
5 checks passed
@adamziel adamziel deleted the try-in-spawn-handler branch April 25, 2024 08:55
@adamziel adamziel mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Aspect] Process Management [Feature] PHP.wasm [Package][@php-wasm] Util [Type] Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adamziel