Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate 404s due to nested files-to-serve-via-php dir #1333

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

brandonpayton
Copy link
Member

@brandonpayton brandonpayton commented Apr 26, 2024

What is this PR doing?

Fixes website breakage due to a files-to-serve-via-php directory being nested within another files-to-serve-via-php-directory. When this occurs, files are more nested than expected and cannot be found.

What problem is it solving?

During deployment we list files within a directory structure and move them conditionally. Because this is done with a find piped to bash functions that move files to files-to-serve-via-php within the same parent dir, it appears moved files are later discovered by find causing them to be moved again and creating a nested directory structure.

How is the problem addressed?

By filtering out paths that include the string files-to-serve-via-php to prevent them from being moved again.

Testing Instructions

  • Manually login to the test site via PHP and run apply-update.sh manually.

@brandonpayton brandonpayton self-assigned this Apr 26, 2024
@brandonpayton brandonpayton merged commit 8eba664 into trunk Apr 26, 2024
5 checks passed
@brandonpayton brandonpayton deleted the fix-nesting-issue-with-wp-cloud-deploy branch April 26, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant