-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show error log if Playground fails to start #1336
Conversation
<a href="https://wordpress.github.io/wordpress-playground/blueprints-api/troubleshoot-and-debug-blueprints"> | ||
check out the documentation | ||
</a>{' '} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use target="_blank"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rewrite proposal:
Oops! There was a problem starting Playground. To figure out what went wrong, please take a look at the error logs provided below. If you see an "Invalid blueprint error," the logs will point out the specific step causing the issue. You can then double-check your blueprint. For more help, you can also visit our documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the crash modal replace this one if the error is a fatal crash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the crash modal replace this one if the error is a fatal crash?
Yes, after fixing eab466f. But it doesn't look good. It first shows the logger and after that the error report modal. I need to find a way to not show logs in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It took me a bit to get to a clean solution, but this should work now 2dfec6f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some questions inline but LGTM otherwise, thank you!
Fixes #1230
What is this PR doing?
It adds a modal that loads if Playground fails to start. The modal contains error details.
What problem is it solving?
It should help users debug startup issues like Blueprint errors.
How is the problem addressed?
By showing a modal with Playground logs when
startPlaygroundWeb
fails to start.Testing Instructions