Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document WP Cloud website setup #1338

Merged
merged 2 commits into from
Apr 27, 2024
Merged

Document WP Cloud website setup #1338

merged 2 commits into from
Apr 27, 2024

Conversation

brandonpayton
Copy link
Member

This PR adds a basic README to explain our WP Cloud setup.


- rewriting URLs
- redirecting requests
- customizing response headers
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where the multiple spaces between the hyphen and the text came from. Perhaps it is from an auto-formatter on commit.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that’s a formatter. I don’t mind but if you find it annoying then let’s change it.

@brandonpayton
Copy link
Member Author

@WordPress/playground-maintainers does this README make sense, and is there anything else you would like to know?

In order to customize these aspects for static files on WP Cloud, we did the following:

- Configured the WP Cloud site to delegate requests for non-existent files to WordPress.
- Provided a `__wp__/index.php` file as a default target for Nginx. - Even though this is not a WordPress site, we can provide a `__wp__/index.php` file that Nginx will run as a fallback for non-existent files. The `__wp__/index.php` file is empty and simply exists so Nginx will invoke PHP.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __wp__/index.php file is empty and simply exists so Nginx will invoke PHP.

What’s the value of simply invoking php?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, I got my answer from the next bullet point

Copy link
Collaborator

@adamziel adamziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great writeup

@adamziel adamziel merged commit a6f7db1 into trunk Apr 27, 2024
5 checks passed
@adamziel adamziel deleted the document-wp-cloud-setup branch April 27, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants