PHP.wasm Node: Revert a part of #1289, do not import a .wasm file #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1289 shipped a PHP.wasm building logic that used an import statement instead of composing a path of __dirname. It did that to support Bun bundling, as Bun needs those static imports to include the .wasm files in the single executable. Unfortunately, that change broke npm bundling and publishing, resulting in a broken package that doesn't ship the correct paths and builds a broken index.cjs file.
adamziel
added
[Type] Bug
|
I'll go ahead and merge without waiting for checks and revert if it goes wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1289 shipped a PHP.wasm building logic that used an import statement instead of composing a path of __dirname. It did that to support Bun bundling, as Bun needs those static imports to include the .wasm files in the single executable. Unfortunately, that change broke npm bundling and publishing, resulting in a broken package that doesn't ship the correct paths and builds a broken index.cjs file.