Website: Fix deploy-time check for file with PHP-handled redirect #1350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This PR solves an issue where
/wordpress.html
was not being served by PHP because it was not moved intofiles-to-serve-via-php
during website deploy. And it was not being moved because the should-serve-via-PHP check relied upon the current referer, which is something we don't know at deploy time.How is the problem addressed?
This PR solves the issue by having the maybe-redirect function return a declaration of its intent to redirect for specific referers. Then we can see there is need for special treatment at deploy time, and the request handler can see the declaration and act upon it at request time.
Testing Instructions
Related to #1197