Website: Avoid edge-caching conditionally redirected resources #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonpayton
added
[Type] Bug
brandonpayton
deleted the
wp-cloud-avoid-caching-file-with-possible-redirect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This PR disables edge caching for conditionally redirected resources.
What problem is it solving?
The WP Cloud edge cache seems to avoid caching some redirects. But for conditionally redirected resources like
/wordpress.html, the edge cache can cache the resource when not redirected, and after that, PHP is no longer given a chance to conditionally redirect.How is the problem addressed?
If a resource has conditional redirects, we now explicitly disable caching for that resource.
Testing Instructions
Related to #1197