Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the GitHub issue link to open in a new tab #1353

Merged
merged 1 commit into from
May 1, 2024
Merged

Updated the GitHub issue link to open in a new tab #1353

merged 1 commit into from
May 1, 2024

Conversation

josevarghese
Copy link
Contributor

What is this PR doing?

Due to the Content Security Policy, the link to the GitHub issue does not open within the Playground 'Add new plugin' and 'Add new theme' pages. To fix this, add the target attribute to load the link in a new tab.

What problem is it solving?

The error occurs when someone clicks on the "experimental, opt-in feature" link within the Playground due to the CSP.

How is the problem addressed?

Added the target attribute to the hyperlink to load the link in a new tab.

Testing Instructions

  1. Open playground
  2. Navigate to the Plugins > Add New Plugins or Appearance > Themes > Add New Theme (button)
  3. You can notice the admin error notice mentioning "Network access is an experimental, opt-in feature, which means you need to enable it to allow Playground to access the Plugins/Themes directories."
  4. Click on the "experimental, opt-in feature" hyperlink, where you can notice the GitHub issue link is not loaded due to the CSP.

Due to the Content Security Policy, the link to the GitHub issue is not opening within the Playground. To fix this, added the target attribute to load it in a new tab.
@adamziel
Copy link
Collaborator

adamziel commented May 1, 2024

Thank you so much @josevarghese!

@adamziel adamziel merged commit 8b9fe82 into WordPress:trunk May 1, 2024
5 checks passed
@adamziel adamziel added [Type] Documentation Improvements or additions to documentation [Type] Enhancement New feature or request labels May 1, 2024
@josevarghese josevarghese deleted the patch-2 branch May 1, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Documentation Improvements or additions to documentation [Type] Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants