Introduce a new @wp-playground/common package to avoid circular depencies #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: I couldn't add a
installSqlitePluginfunction to@wp-playground/wordpressas it imported Blueprints which already relied on@wp-playground/wordpress.The new
@wp-playground/commonpackage should give us some leeway to start implementing parts of the boot pipeline similarly to@php-wasm/util.As a side note, I'm not a fan of these "common" packages as they tend to grow indefinitely overtime and attract every bit of code that doesn't fit anywhere else. Let's be extra careful when adding new "common" functions and always ask "is my design right? could this be structured differently? before adding more code.
Testing instructions
Confirm the unit tests pass