Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VSCode branch protection #1408

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

bgrgicak
Copy link
Collaborator

What is this PR doing?

Adds trunk branch protection to VSCode.

What problem is it solving?

I was able to directly push to trunk which is protected by clicking the wrong button in VSCode which shouldn't happen.
As a maintainer, I can override branch protection and VSCode did it for me this time.

How is the problem addressed?

By adding a branchProtection VSCode setting.

Testing Instructions

This can't be tested without trying to push to trunk.

@bgrgicak bgrgicak requested a review from a team May 16, 2024 05:12
@bgrgicak bgrgicak self-assigned this May 16, 2024
@adamziel adamziel merged commit 1237e8b into trunk May 16, 2024
5 checks passed
@adamziel adamziel deleted the update/add-vscode-branch-protection branch May 16, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants