Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore nightly wordpress build #1437

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

brandonpayton
Copy link
Member

@brandonpayton brandonpayton commented May 21, 2024

What is this PR doing?

This PR restores the nightly WordPress build target which appears to have been inadvertently removed by c6d06f2.

How is the problem addressed?

It restores the "bundle-wordpress:nightly" target that was present immediately before removal.

Testing Instructions

  • Run: export FORCE_REBUILD=true; npx nx run --skip-nx-cache playground-wordpress-builds:bundle-wordpress:nightly
  • Observe that it produces a new version of the nightly build.
  • Run npm run dev and confirm you can run Playground from the dev server using the nightly WP version

cc @adamziel

@brandonpayton brandonpayton added [Type] Bug An existing feature does not function as intended [Package][@wp-playground] WordPress Builds labels May 21, 2024
@brandonpayton brandonpayton requested a review from adamziel May 21, 2024 01:01
@brandonpayton brandonpayton self-assigned this May 21, 2024
@brandonpayton
Copy link
Member Author

This PR also includes an updated nightly WordPress build.

@brandonpayton
Copy link
Member Author

I also reran the "bundle-sqlite-database" build target, which was moved, and made sure there were no errors.

@brandonpayton brandonpayton merged commit 75c19ab into trunk May 21, 2024
5 checks passed
@brandonpayton brandonpayton deleted the restore-nightly-wordpress-build branch May 21, 2024 01:14
@adamziel
Copy link
Collaborator

Oh, good spot and thank you!

@brandonpayton
Copy link
Member Author

Oh, good spot and thank you!

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package][@wp-playground] WordPress Builds [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants