Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name to Puzzle package #1443

Merged
merged 1 commit into from
May 21, 2024
Merged

Add name to Puzzle package #1443

merged 1 commit into from
May 21, 2024

Conversation

bgrgicak
Copy link
Collaborator

@bgrgicak bgrgicak commented May 21, 2024

What is this PR doing?

Adds a name to the Playground Puzzle package.

What problem is it solving?

There is an error with NPM deployments caused by the missing package name.

Related error https://github.com/WordPress/wordpress-playground/actions/runs/9176130514/job/25230708282

How is the problem addressed?

By adding a name to the Puzzle app package.json

Testing Instructions

  • Ensure all tests pass

@bgrgicak bgrgicak self-assigned this May 21, 2024
@bgrgicak bgrgicak requested a review from a team May 21, 2024 14:39
@bgrgicak bgrgicak added the [Type] Bug An existing feature does not function as intended label May 21, 2024
Copy link
Collaborator

@sejas sejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the quick fix.

I observed that website does not have a name either. But it seems to be fine, because the error message says: Package name "undefined" used in multiple packages , so it's fine to have one undefined, but not having two 😆 .

Error from CI:
https://github.com/WordPress/wordpress-playground/actions/runs/9176130514/job/25230708282

Run npx lerna@6.6.2 publish patch --yes --no-private --loglevel=verbose --dist-tag=latest
lerna notice cli v6.6.2
lerna verb rootPath /home/runner/work/wordpress-playground/wordpress-playground
lerna info ci enabled
lerna ERR! ENAME Package name "undefined" used in multiple packages:
lerna ERR! ENAME 	/home/runner/work/wordpress-playground/wordpress-playground/packages/playground/puzzle
lerna ERR! ENAME 	/home/runner/work/wordpress-playground/wordpress-playground/packages/playground/website
Error: Process completed with exit code 1.

@bgrgicak
Copy link
Collaborator Author

I observed that website does not have a name either. But it seems to be fine, because the error message says: Package name "undefined" used in multiple packages , so it's fine to have one undefined, but no having two 😆 .

Yes, let's take a look at that separately. I don't want to mess up that package. The puzzle package still isn't in use so there won't be any harm in adding it.

@bgrgicak bgrgicak merged commit 37c0a1a into trunk May 21, 2024
5 checks passed
@bgrgicak bgrgicak deleted the fix/puzzle-package-name branch May 21, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants