Update remaining localhost:5400 refs to 127.0.0.1:5400 #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonpayton
added
[Type] Bug
|
As these are low-risk changes, I'll go ahead and merge. |
bgrgicak
pushed a commit
that referenced
this pull request
Jun 20, 2024
## Motivation for the change, related issues There are some code and documentation references that still point to `localhost:5400` for dev even though the correct address is now `127.0.0.1:5400`. ## Implementation details This updates the plaintext references to `127.0.0.1:5400` and also updates the JSPI origintrial string to reference the correct address. I tested this update with the `jspi` branch, and the dev server running on the `jspi` branch loads in Chrome but only after this change. ## Testing Instructions (or ideally a Blueprint) - CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
There are some code and documentation references that still point to
localhost:5400for dev even though the correct address is now127.0.0.1:5400.Implementation details
This updates the plaintext references to
127.0.0.1:5400and also updates the JSPI origintrial string to reference the correct address. I tested this update with thejspibranch, and the dev server running on thejspibranch loads in Chrome but only after this change.Testing Instructions (or ideally a Blueprint)