-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add npm run fix-asyncify
task that adds the missing ASYNCIFY_ONLY items
#253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Bug
An existing feature does not function as intended
[Type] Developer Experience
Mission-critical
[Aspect] Asyncify
labels
May 5, 2023
adamziel
commented
May 5, 2023
adamziel
force-pushed
the
automate-asyncify-debugging
branch
from
May 9, 2023 14:37
fd4d1cd
to
302ea84
Compare
56 tasks
I cleaned this one up. I'll merge once the tests pass |
One more update needed here, I don't think all the PHP versions were correctly rebuilt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Aspect] Asyncify
Mission-critical
[Type] Bug
An existing feature does not function as intended
[Type] Developer Experience
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #251
Description
With this commit, fixing Asyncify issues only requires:
packages/php-wasm/node/src/test/php-asyncify.spec.ts
npm run fix-asyncify
The
npm run fix-asyncify
commandTo make it all work, this PR:
PHP.run()
Follow-up work
php-asyncify.spec.js
cc @sejas @danielbachhuber