BasePHP: Use FS.rename for mv method

[eliot-akira]

What?

Update BasePHP.mv method to use FS.rename instead of FS.mv which doesn't exist.

Why?

The FS method is called rename, not mv, in both Emscripten and Node.js.

• https://emscripten.org/docs/api_reference/Filesystem-API.html#FS.rename
• https://nodejs.org/api/fs.html#fsrenameoldpath-newpath-callback

Testing Instructions

1. Check out the branch.
2. Run npx nx test php-wasm-node.

[adamziel]

This is great @eliot-akira, thank you so much for finding and fixing this at the framework level – this benefits every Playground project!

[adamziel]

Would you also add a unit test to prevent any future regressions? They live in php-wasm/node/src/test/php.spec.ts for now.

[eliot-akira]

Sure, I added the following tests:

• mv() should move a file
• mv() should replace target file if it exists
• mv() should throw a useful error when source file does not exist
• mv() should throw a useful error when target directory does not exist

[adamziel]

10/10 💯