Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website query API: Continue plugin installs on error #605
Website query API: Continue plugin installs on error #605
Changes from all commits
797dce0
71f32d9
c6fbe1f
38791f2
71b2467
486a632
bc803cd
5fb2d41
1281355
4681f81
4722601
69eb4af
978a3fa
c8467b1
06d7f26
df14575
4243e59
b32c27b
c7b7920
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this wait forever if the
finally
section is triggered by an error thrown before all the steps are run?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point, no further steps are executed. Also, nothing seems to await
stepPromises
– do we need to reason about status as promises, then? Or could the status information be stored in a synchronous data structure likeMap<StepDefinition, { didRun, error, result }>
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This type coersion to
CorePluginReference
is questionable. It was a temporary workaround becausestep.pluginZipFile
is aFileReference
, a union of several types which have propertyslug
,name
,path
, or nothing for the name.