Fix a cross-device mv error by using a tmp directory inside document root #886
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Solves the error discovered by @sejas caused by calling
php.mv(fromPath, toPath)
whenfromPath
is a mounted local directory andtoPath
is a MEMFS directory. Emscripten doesn't support such a scenario:The solution proposed in this PR replaces a
/tmp
directory with a randomly-named temporary directory insidewp-content
./tmp
doesn't necessarily point to a system temp directory and needs to be revisited anyway. Whether we should use a temporary directory insidewp-content
is another matter, but that part may be revisited once the recursive cp feature is added.Testing instructions
npm run build
)