This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
i18n: Merge similar translation strings #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mukeshpanchal27
commented
Mar 26, 2020
•
mukeshpanchal27
commented
jeffpaul
reviewed
Mar 26, 2020
wp-autoupdates.php
Outdated
| @@ -731,15 +731,15 @@ function wp_autoupdates_debug_information( $info ) { | |||
| /* translators: %s: Latest plugin version number. */ | |||
| $plugin_version_string .= ' ' . sprintf( __( '(Latest version: %s)', 'wp-autoupdates' ), $plugin_updates[ $plugin_path ]->update->new_version ); | |||
| /* translators: %s: Latest plugin version number. */ | |||
| $plugin_version_string_debug .= ' ' . sprintf( __( '(latest version: %s)', 'wp-autoupdates' ), $plugin_updates[ $plugin_path ]->update->new_version ); | |||
| $plugin_version_string_debug .= ' ' . sprintf( __( '(Latest version: %s)', 'wp-autoupdates' ), $plugin_updates[ $plugin_path ]->update->new_version ); | |||
There was a problem hiding this comment.
Why not completely collapse this into $plugin_version_string?
There was a problem hiding this comment.
Hi @jeffpaul,
$plugin_version_string and $plugin_version_string_debug both variable used for diffrent pepose.
$plugin_version_string in value and $plugin_version_string_debug use for debug
There was a problem hiding this comment.
Yep.
However @mukeshpanchal27 I think it would be better to use the lowercase version 😃
Can you please update the patch accordingly?
Thank you!
audrasjb
suggested changes
Mar 27, 2020
wp-autoupdates.php
Outdated
| @@ -731,15 +731,15 @@ function wp_autoupdates_debug_information( $info ) { | |||
| /* translators: %s: Latest plugin version number. */ | |||
| $plugin_version_string .= ' ' . sprintf( __( '(Latest version: %s)', 'wp-autoupdates' ), $plugin_updates[ $plugin_path ]->update->new_version ); | |||
| /* translators: %s: Latest plugin version number. */ | |||
| $plugin_version_string_debug .= ' ' . sprintf( __( '(latest version: %s)', 'wp-autoupdates' ), $plugin_updates[ $plugin_path ]->update->new_version ); | |||
| $plugin_version_string_debug .= ' ' . sprintf( __( '(Latest version: %s)', 'wp-autoupdates' ), $plugin_updates[ $plugin_path ]->update->new_version ); | |||
There was a problem hiding this comment.
Yep.
However @mukeshpanchal27 I think it would be better to use the lowercase version 😃
Can you please update the patch accordingly?
Thank you!
audrasjb
reviewed
Mar 27, 2020
audrasjb
approved these changes
Mar 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.