-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Enterprise content and design #150
Comments
I've put an initial version of the new Enterprise website together. You'll need to preview from the WordPress editor to experience it, but I'll include some screenshots. I'd recommend opening the page in the editor and clicking 'preview' to get the full experience. Overall using Gutenberg worked really well, but I do have some questions and things I'd like to double-check regarding the design. @ryelle @StevenDufresne Apologies if these questions are explained elsewhere, but I wanted to make sure I understood the intended way to work with the parent theme when tweaks are needed:
@panchovm I'm curious if you have thoughts about how the design looks.
URL: https://wordpress.org/enterprise-2/ (open in editor and preview) |
You can use that character directly,
Maybe Media & Text? I’m not sure, without playing with GB myself.
This has been a common problem… Using the “Large” preset for left & right padding should respond pretty closely to what's expected (with some ongoing work there, still - see WordPress/wporg-showcase-2022#62).
Try using the “CTA Heading” font size, it will scale down on mobile automatically. Some of the font size presets (and spacing presets) already scale by default - you can see the list of values here. |
Is |
If it's for any of the "main" sections (About, Downloads, Enterprise) then yes definitely. Showcase, Themes, Documentation, the Developer Blog, and the Developer site have their own repos. The parent theme repo is a good place for anything that affects multiple sites (like the brush stroke, or other patterns planned to be reused). Other sites' repos will be made when development is started there. That said, it's very easy to transfer issues from one GH repo to another, so don't worry too much about putting something in the "wrong" place. |
Thank you for the direction @ryelle , it looks much better on mobile now after making some of those tweaks. @panchovm This is ready for design review. Would you be able to take a look this week and let me know your thoughts on my above questions? @thetinyl While the new 'Enterprise' landing page is using mostly the same content as the current site, I was wondering if somebody would be able to review the content and make any necessary content updates. If anything is difficult to update, just let me know what needs to be changed, and I'd be happy to do so. For both Francisco and Lauren, to edit the page, you'd go to https://wordpress.org/enterprise-2/ and edit the page in WordPress. You won't be able to see the new design changes until you click the 'preview' button. Feel free to modify any content or design if it makes it more efficient to make updates. Thank you in advance for taking a look. |
The page looks good, I noticed just a few inconsistencies in text styles and spacings. But open to following developed styles. Hero section and stylesThe section has a small top padding. A Paragraph in the right side needs to have the following:
Brand logos
Use cases section
Features sectionThe section needs to have a spacing of
Resources links
QuestionsIn general, two things came up to me while reviewing the desktop version:
I will split my comments on the mobile version since I have not shared any design. |
Thanks for the tag @bengreeley! I reviewed the content and made a few tweaks to comply with the updated brand writing style guide, as well as for clarity. I noticed there is a bit of repetition across a couple of sections and did my best to adjust (without any major wordsmithing) to make it feel less so. To quickly outline some of the updates:
Overall, I think this page's content could use some TLC in the future. If we were open to doing a quicker follow-up content update, I think the "Enterprise use cases" section could be improved without too much effort: I think there's more we could say here about why these particular sectors are using WordPress. In general, and from a branding perspective, it could be more benefit driven (and empowering). |
Coming back here to share the mobile version. Here is a small view of the mockup, but you can see its Figma version in this link. |
@panchovm First of all, thank you so much for the feedback and pointing me in the direction of the mobile Figma. I was able to mostly achieve what you're looking for, but there are some caveats that I'll outline below that I'd like to get your opinion on. Since we are putting these landing pages together within the Gutenberg editor, there are certain limitations of what we can do on mobile that is different from the desktop version. I'd like to see what you think about possible alternatives that might simplify the implementation:
Let me know if you have any other thoughts on how to achieve the designs purely through the editor. Thanks again. |
@panchovm FYI I changed the background color to be charcoal-2 to match the existing pages (see this GitHub issue for the conversation). Let me know if you think it actually should be |
@adamwoodnz are you able to take a look and help sort out the logo issues? |
Thanks for addressing my comments @bengreeley. Replying per point:
Not at all. We might need to increase the image resolution, but I wonder how we’re addressing all images on the site to follow that rule.
I saw @adamwoodnz's solution, and it looks excellent.
Thanks for opening ticket #307, I shared my thought there to continue with
The other solution I was thinking of is replacing it with a horizontally-arranged version for mobile, but that might be undoable as well. The current implementation takes a significant portion of the screen, so I am drawn to hide the image. Another solution might be redesigning that section to not rely on any image and possible layout breaks. What do you think?
It works well as it is ✨ Thanks for the improvement. It looks great. |
Some other thoughts where I would like your opinion for what is the best approach to tackle them. GeneralDoble borderI noticed a double border on each feature's top side. This might be to solve the divider on mobile. If that is the case, it seems better to remove the border of all features completely. Showing a screenshot. Heading styleThe E-commerce heading looks bolder than the same section's other headings. MobileParagraph widthThe description text in hero section looks narrow Spacing in Features sectionThe features section have a left and right padding that sets the content off the grid. This makes the page to look broken. |
@adamwoodnz Yes, if you have time to help wrap things up on this page, I'd appreciate it. As I see it, we'd need to do the following:
Let me know if you have any questions. This isn't a super-high priority, but it would be nice to have ready for next week. |
We have an active(ish) issue for that here: WordPress/wporg-mu-plugins#300 — In the meantime, we've been using |
OK I'll get a PR ready with a pattern for the page and any final custom CSS for the things mentioned above |
PR is ready for review #157 |
I'm aware there are still some minor padding issues on some sections on mobile. I propose we get the initial code review done and merged, then we can apply the template to the test page and it'll be ready for a final design review. |
@panchovm @javierarce code review is now complete on #157 We're looking to launch this next week, so any final design feedback would be appreciated please. See these screenshots #157 (comment) cc @bengreeley |
This design is still in progress, not yet final.
(updated with newer design)
The text was updated successfully, but these errors were encountered: