Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt to reset the Meetup API authentication tokens, as we can't do it automatically. #317

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

dd32
Copy link
Member

@dd32 dd32 commented Jan 5, 2023

At some point in the past while debugging a Meetup API issue, I was forced to change how the authentication reset process works, I'm unsure what the issue was, but it likely pre-dated the files being canonicalised here.

Recently (likely after the meetup.com password was changed) the events api ceased to import meetup events, throwing the following warning:

E_USER_WARNING:
   Official_WordPress_Events::handle_error_response error for [make.wordpress.org](http://make.wordpress.org/):
   HTTP Code: 400 Message: Bad Request
   Body: {"error_description":"Unknown or previously used refresh_token","error":"invalid_grant"}

It seems like running the request with these changes, and re-authenticating the oAuth applications has restored the meetup.com ingestion.

The changes in this PR have been sitting in my development environment since ~May 2022, so I don't recall the exact reasoning behind it, other than it was likely to resolve this same error.
It looks like the main thing is that it attempts to check the refresh_token is valid and errors out if not, where as currently it seems to assume that the refresh_token will never be invalid. I think.

This is a PR for now as I wanted to get the code off my hands and somewhere for others; I haven't fully tested and reviewed these changes to verify it does exactly what I think it does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant