Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine header styles #5

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Refine header styles #5

merged 2 commits into from
Sep 27, 2021

Conversation

iandunn
Copy link
Member

@iandunn iandunn commented Sep 7, 2021

@iandunn iandunn added the [Type] Enhancement New feature or request label Sep 7, 2021
@iandunn iandunn self-assigned this Sep 7, 2021
@iandunn iandunn changed the title Refine header/footer styles Refine header styles Sep 22, 2021
@iandunn iandunn force-pushed the refine-head-foot-styles branch 2 times, most recently from 36de41e to 827a9c9 Compare September 24, 2021 20:26
@iandunn iandunn marked this pull request as ready for review September 24, 2021 20:30
@iandunn
Copy link
Member Author

iandunn commented Sep 24, 2021

This doesn't include the search or mobile menu, those will be in future PRs. It's also not trying to be pixel perfect yet, just getting the bulk of it done.

One problem I ran into is that adding Patterns and Openverse to the header made it too big to fit the design breakpoints. I tested out a submenu for the "resource" type links, and I think it works pretty well:

Screen Shot 2021-09-24 at 1 33 38 PM

I'm curious to hear what others think, though. cc @beafialho

@beafialho
Copy link

One problem I ran into is that adding Patterns and Openverse to the header made it too big to fit the design breakpoints. I tested out a submenu for the "resource" type links, and I think it works pretty well:

I like this solution @iandunn. Regarding the term "Add-ons", my only comment is I think it makes more sense to label it "Resources". The term Add-ons might be mistaken by some users not as familiar with WP as referring only to tools you can add to your site, whereas Resources feels broader with all the items you need to build your site.

@iandunn
Copy link
Member Author

iandunn commented Sep 27, 2021

That's a good point, we definitely want to communicate both add and build.

Do you think people will make the connection between those actions and "Resources", though? If I saw it, I'd assume it refers more to things like documentation or support.

Is there a word that's more descriptive than both "Addons" and "Resources"?

@beafialho
Copy link

If I saw it, I'd assume it refers more to things like documentation or support.

That's also a good point. I've noticed that the current "Support" page links to Documentation, so maybe the label would be "Support" and Documentation, Forums and Guidelines would be its submenus?

There is also "Tools" instead of "Resources".

@iandunn
Copy link
Member Author

iandunn commented Sep 27, 2021

maybe the label would be "Support" and Documentation, Forums and Guidelines would be its submenus?

I agree that'd be ideal. IIRC, though, the forums are intentionally a little hard to find, because the support team was overwhelmed by folks who didn't try to read docs first. The idea is to encourage folks to "self-serve" a bit before asking for other people's time.

There is also "Tools" instead of "Resources".

🤔 I think that's a good one for plugins, but doesn't work as well for Themes, Patterns, Blocks, and Images/Openverse.

Maybe it'd be good to have a discussion on the designp2, and xpost to a few other teams, to get more perspectives on it? I think it'll be hard to come up with a good word with just a few people.

The News site isn't going to launch fo awhile, so we have plenty of time.

@iandunn iandunn merged commit 22a1b19 into trunk Sep 27, 2021
@iandunn iandunn deleted the refine-head-foot-styles branch September 27, 2021 21:02
@iandunn
Copy link
Member Author

iandunn commented Sep 27, 2021

i applied corey's suggestions in 2be4821

i went ahead and merged this w/ the add-on menu, b/c it's easier when we don't have lots of open interconnected prs. i'll switch to the ... overflow menu in the next pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants