Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New block: Chapter List #650

Merged
merged 2 commits into from
Sep 11, 2024
Merged

New block: Chapter List #650

merged 2 commits into from
Sep 11, 2024

Conversation

ryelle
Copy link
Contributor

@ryelle ryelle commented Sep 10, 2024

This ports the "Chapter list" block from Developer to the mu-plugins so it can be used on other handbook sites (Five for the Future, in this case).

The only change to the code was setting up some default CSS, so the styles in the child theme.json can be removed.

See WordPress/wporg-developer#539

Screenshots

There should be no visual changes.

Screen Shot 2024-09-10 at 17 07 02

Screen Shot 2024-09-10 at 17 14 08

To test

  1. Apply this PR, build files
  2. Apply the wporg-developer PR Blocks: Remove Chapter List wporg-developer#539
  3. OR, test with Five for the Future, if you have handbook content set up locally
  4. View a handbook page
  5. The "Chapter list" left sidebar should appear
  6. It should work like production— a list of page links, with the current item bold
  7. It should scroll with the page content, unless it's longer than the footer in which case it will scroll internally

Copy link
Contributor

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local developer site and LGTM.

Haven't tested 5ftf.

@ryelle ryelle merged commit 3f82d10 into trunk Sep 11, 2024
2 checks passed
@ryelle ryelle deleted the add/blocks-chapter-list branch September 11, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants