Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

130 contributing cannot be done with current instructions #131

Conversation

jissagn
Copy link
Contributor

@jissagn jissagn commented Jun 30, 2023

This is a PR that intends to fix #130.
One missing item though : I did not find a proper way to load the .env file during tests.

@chainyo
Copy link
Contributor

chainyo commented Jul 1, 2023

Hi @jissagn, we won't include nox and nox-poetry directly in the dependencies, even for the dev group. It should be installed for your Python projects but not linked to one project.

But we should improve the workflow / contributing explanations by adding some pre-requisites steps like:

pipx install nox
pipx inject nox nox-poetry

This is usually a great local install step I tend to use: https://cookiecutter-hypermodern-python.readthedocs.io/en/2022.6.3.post1/guide.html#requirements

jissagn added 2 commits July 4, 2023 14:09
The `--no-cache` option is to ensure that poetry won't try to reuse
packages that are already installed outside the venv (in order to avoid
read/write permission errors, and remain clearly separated)
@jissagn jissagn force-pushed the 130-contributing-cannot-be-done-with-current-instructions branch from b59a026 to da7c676 Compare July 4, 2023 12:28
@jissagn jissagn marked this pull request as ready for review July 4, 2023 12:29
Copy link
Contributor

@chainyo chainyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@chainyo chainyo merged commit 60eb8a7 into Wordcab:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributing cannot be done with current instructions
2 participants