Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the api #213

Merged
merged 12 commits into from
Aug 14, 2023
Merged

Update the api #213

merged 12 commits into from
Aug 14, 2023

Conversation

chainyo
Copy link
Contributor

@chainyo chainyo commented Aug 11, 2023 •
edited
Loading

Fixes #210 #211 #212

This PR:

  • Update time_and_tell to add process_times to the API outputs
  • Use lifespan instead of deprecated startup method in FastAPI
  • Update logging middleware for tracing requests with uuid
  • Add new API parameters for more control over transcription
  • Remove use_batch parameter
  • Clean the transcribe_service file from the unsuccessful batch attempt 😢

@chainyo chainyo linked an issue Aug 11, 2023 that may be closed by this pull request
Update the API #212
Closed
@chainyo chainyo added api Everything related to the API implementation transcription Everything related to the transcription part labels Aug 11, 2023
@aleksandr-smechov aleksandr-smechov marked this pull request as draft August 11, 2023 20:12
@aleksandr-smechov aleksandr-smechov marked this pull request as ready for review August 11, 2023 20:21
@aleksandr-smechov aleksandr-smechov self-requested a review August 12, 2023 02:19
@aleksandr-smechov aleksandr-smechov merged commit 2747c03 into main Aug 14, 2023
@chainyo chainyo mentioned this pull request Aug 16, 2023
Merged
@chainyo chainyo deleted the 212-update-the-api branch September 1, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandr-smechov aleksandr-smechov Awaiting requested review from aleksandr-smechov

Assignees
No one assigned
Labels
api Everything related to the API implementation transcription Everything related to the transcription part
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the API Clean the transcribe file
2 participants
@chainyo @aleksandr-smechov