[PROD-36670] Expose new headerValueCallback option that will called on every visible header #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… header PROD-36670
nikostoulas
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR exposes a new callback function, the
headerValueCallback. This function will be called on every visible header. And will give the ability to mutate the value of the header that will be logged.This is useful in cases where the header value contains sensitive data that needed to be hide.
This PR is created as part of fixing the following issue: https://workable.atlassian.net/browse/PROD-36670
where the JWT token is part of the
locationheader and although that thelocationheader is needed to be logged it is also needed to not includeid_tokenas part of it, because of a security issue.