Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF Enhancements for FormField Label Text #2809

Closed
myvuuu opened this issue Jun 27, 2024 · 0 comments · Fixed by #2881
Closed

FF Enhancements for FormField Label Text #2809

myvuuu opened this issue Jun 27, 2024 · 0 comments · Fixed by #2881
Assignees
@mannycarrera4
Labels
12.x
Milestone
12.0.0

Comments

@myvuuu
Copy link
Collaborator

myvuuu commented Jun 27, 2024 •
edited
Loading

💡 Suggestion

Add the following enhancements to FormField Label Text:

  • Enable left/right label alignment
  • Enable text wrapping for label text
  • Enable padding adjustment between label text and input container
  • Create examples / recipes
  • Create tests
  • Validate enhancements can be applied to: Text Input, Text Area, Select, Radio, and Checkbox

Motivation

What are the key benefits if this suggest was included to Canvas-Kit?

Example

Please provide some examples of this suggestion in practice.
@myvuuu myvuuu added the 12.x label Jul 1, 2024
@myvuuu myvuuu added this to the 12.0.0 milestone Jul 1, 2024
@myvuuu myvuuu mentioned this issue Jul 18, 2024
Open
@mannycarrera4 mannycarrera4 mentioned this issue Aug 21, 2024
Merged
10 tasks
@jaclynjessup jaclynjessup linked a pull request Sep 9, 2024 that will close this issue
feat: Add horizontal start and end label position for form field #2881
Merged
10 tasks
alanbsmith pushed a commit that referenced this issue Sep 12, 2024
@mannycarrera4 @josh-bagwell
feat: Add horizontal start and end label position for form field (#2881)
bd882e1 
Fixes: #2809

[category:Components]

Release Note:
The orientation prop on the FormField component will be updated to accept the following values: `vertical`, `horizontalStart`, and `horizontalEnd`. `horizontal` will still be accepted as a value in v12, but it will be deprecated and slated for removal in a future major release. These changes are intended to provide more flexibility with label alignments on FormField elements.

Instances where the orientation prop of the FormField component is set to `horizontal` will automatically default to `horizontalStart` via a codemod. A console warning message will also appear with a message to change the prop value to either horizontalStart or horizontalEnd.

Co-authored-by: manuel.carrera <manuel.carrera@workday.com>
Co-authored-by: @josh-bagwell <44883293+josh-bagwell@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mannycarrera4 mannycarrera4

Labels
12.x
Projects
Canvas Kit
Status: ✅ Done
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

feat: Add horizontal start and end label position for form field mannycarrera4/canvas-kit
2 participants
@mannycarrera4 @myvuuu