feat(modal): Add support for scrolling a modal #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
NicholasBoll
commented
Sep 10, 2021
NicholasBoll
commented
Sep 10, 2021
6 tasks
felipsbreno
approved these changes
Nov 16, 2021
NicholasBoll
force-pushed
the
feat/overflow-modal-support
branch
from
51c5999
to
1de255f
Compare
NicholasBoll
commented
Jan 24, 2022
| return ( | ||
| <Stack as={Element} ref={ref} flexDirection={flexDirection} {...elemProps}> | ||
| <Stack as={Element} ref={ref} flexDirection="column" {...elemProps}> |
There was a problem hiding this comment.
Changes to this file are optional. The changes simplify Stack by removing unnecessary Typescript and decreasing prop name duplication.
mannycarrera4
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #790
This PR changes the structure of Modals slightly by removing the extra
divin theModal.BodyandPopup.Bodyand instead adds the type thatCard.Bodyadds manually. This allows theModal.Bodyto be more easily styled, but may be a breaking change. This change also allows overflow to be applied to Modals.