Merge pull request #587 from Working-Title-MSFS-Mods/cj4-fix-autopilot

CJ4: Fix autopilot PIDS (0.7.3)
Working-Title-MSFS-Mods · Dec 1, 2020 · 348bb47 · 348bb47
2 parents 3eb5108 + 5f376ac
commit 348bb47
Show file tree

Hide file tree

Showing 8 changed files with 74 additions and 24 deletions.
diff --git a/PackageDefinitions/workingtitle-aircraft-cj4-metapackage.xml b/PackageDefinitions/workingtitle-aircraft-cj4-metapackage.xml
@@ -1,4 +1,4 @@
-<AssetPackage Name="workingtitle-aircraft-cj4" Version="0.7.1">
+<AssetPackage Name="workingtitle-aircraft-cj4" Version="0.7.3">
 	<ItemSettings>
 		<ContentType>CUSTOM</ContentType>
 		<Title>CJ4</Title>

diff --git a/PackageDefinitions/workingtitle-aircraft-cj4.xml b/PackageDefinitions/workingtitle-aircraft-cj4.xml
@@ -1,4 +1,4 @@
-<AssetPackage Name="workingtitle-aircraft-cj4" Version="0.7.1">
+<AssetPackage Name="workingtitle-aircraft-cj4" Version="0.7.3">
 	<ItemSettings>
 		<ContentType>CUSTOM</ContentType>
 		<Title>CJ4</Title>

diff --git a/docs/workingtitle-cj4/CHANGES.md b/docs/workingtitle-cj4/CHANGES.md
@@ -1,31 +1,16 @@
-# Working Title CJ4 v0.7.2 Changes
+# Working Title CJ4 v0.7.3 Changes
 
-Welcome to the latest update of the Working Title CJ4 (v0.7.2). This is a hotfix for v0.7.1 for some compatibility changes after MSFS update 1.11.6.0! Thanks to all the helpful folks who contributed to this release.
+Welcome to the latest update of the Working Title CJ4 (v0.7.2). This is a hotfix for adjusting the autopilot PIDs to get rid of the bugs introduces with MSFS update 1.11.6.0! 
 
-## Important Feature Change from v0.7.0 Onward
-
-The active flight plan route will no longer be displayed in the ARC or ROSE modes. This is accurate to the actual aircraft. The ARC and ROSE modes are designed to work with the course pointer system. If you would like to see the flight plan route, you must use the PPOS display mode (very similar to ARC, except with the active flight plan instead of pointers) or the PLAN mode.
-
-To activate the new altitude select range indicator (altitude banana), press DSPL MENU on the FMC, then go to page 2. Press LSK3L to activate the indicator. The indicator will only be displayed in the PPOS mode.
-
----
-
-Demo video: [Working Title CJ4 0.7.0 Features Showcase](https://www.youtube.com/watch?v=ta8SQSLStTM)
-
-Feel free to test out our new Simbrief Profile: [SIMBRIEF PROFILE](https://www.simbrief.com/system/dispatch.php?sharefleet=eyJ0cyI6IjE2MDI1MzkxMTUxODMiLCJiYXNldHlwZSI6IkMyNUMiLCJjb21tZW50cyI6IldPUktJTkcgVElUTEUgQ0o0IiwiaWNhbyI6IkMyNUMiLCJuYW1lIjoiQ0lUQVRJT04gQ0o0IiwiZW5naW5lcyI6IkZKNDQtNEEiLCJyZWciOiJONTI1V1QiLCJmaW4iOiIyNTQiLCJzZWxjYWwiOiIiLCJoZXhjb2RlIjoiIiwiY2F0IjoiTSIsInBlciI6IkIiLCJlcXVpcCI6IlNERTJFM0ZHSFJXWFlaIiwidHJhbnNwb25kZXIiOiJMQjEiLCJwYm4iOiJBMUIyQzJEMkQzTzJPM1MyIiwiZXh0cmFybWsiOiIiLCJtYXhwYXgiOiI3Iiwid2d0dW5pdHMiOiJMQlMiLCJvZXciOiIxMDI4MCIsIm16ZnciOiIxMjUwMCIsIm10b3ciOiIxNzExMCIsIm1sdyI6IjE1NjYwIiwibWF4ZnVlbCI6IjU3NjIiLCJwYXh3Z3QiOiIxNzAiLCJkZWZhdWx0Y2kiOiIiLCJmdWVsZmFjdG9yIjoiUDAwIiwiY3J1aXNlb2Zmc2V0IjoiUDAwMDAifQ--)
-
-Check out our interim SoP doc: [Interim SoP Document](https://docs.google.com/document/d/15qb3g2ECsA8XH6gSbqbe5kGydNJ3Tj0j7vJPAWirwh4/edit?usp=sharing)
-
----
+Thanks to Asobo and FBW for finding a solution to this pressing issue.
 
 ## Installation
 Installation is easy, simply copy the `workingtitle-aircraft-cj4` folder inside the zip file to your MSFS Community folder. 
 
 **Important: We recommend that you fully delete the previous `workingtitle-aircraft-cj4` folder before copying this release.**
 
 ## Changes
-* Fixed SimBrief import for compatibility with 1.11.6.0
-* Fixed Mach Hold not synchronizing with mach changes
+* Changed Autopilot PID values to get rid of problems introduces with MSFS update 1.11.6.0
 
 ## Known Issues
 * Altitude constraints are not currently selectable on the map due to incorrect data being displayed.

diff --git a/docs/workingtitle-cj4/README.md b/docs/workingtitle-cj4/README.md
@@ -1,7 +1,7 @@
 # Working Title CJ4 Mod
 
 ## UPDATES
-Latest Version: [v0.7.2](https://github.com/Working-Title-MSFS-Mods/fspackages/releases/tag/cj4-v0.7.2)
+Latest Version: [v0.7.3](https://github.com/Working-Title-MSFS-Mods/fspackages/releases/tag/cj4-v0.7.3)
 
 Changelog: [CHANGES.md](https://github.com/Working-Title-MSFS-Mods/fspackages/blob/main/docs/workingtitle-cj4/CHANGES.md)
 

diff --git a/docs/workingtitle-cj4/Working Title CJ4 v0.7.2 Changes.md b/docs/workingtitle-cj4/Working Title CJ4 v0.7.2 Changes.md
@@ -0,0 +1,36 @@
+# Working Title CJ4 v0.7.2 Changes
+
+Welcome to the latest update of the Working Title CJ4 (v0.7.2). This is a hotfix for v0.7.1 for some compatibility changes after MSFS update 1.11.6.0! Thanks to all the helpful folks who contributed to this release.
+
+## Important Feature Change from v0.7.0 Onward
+
+The active flight plan route will no longer be displayed in the ARC or ROSE modes. This is accurate to the actual aircraft. The ARC and ROSE modes are designed to work with the course pointer system. If you would like to see the flight plan route, you must use the PPOS display mode (very similar to ARC, except with the active flight plan instead of pointers) or the PLAN mode.
+
+To activate the new altitude select range indicator (altitude banana), press DSPL MENU on the FMC, then go to page 2. Press LSK3L to activate the indicator. The indicator will only be displayed in the PPOS mode.
+
+---
+
+Demo video: [Working Title CJ4 0.7.0 Features Showcase](https://www.youtube.com/watch?v=ta8SQSLStTM)
+
+Feel free to test out our new Simbrief Profile: [SIMBRIEF PROFILE](https://www.simbrief.com/system/dispatch.php?sharefleet=eyJ0cyI6IjE2MDI1MzkxMTUxODMiLCJiYXNldHlwZSI6IkMyNUMiLCJjb21tZW50cyI6IldPUktJTkcgVElUTEUgQ0o0IiwiaWNhbyI6IkMyNUMiLCJuYW1lIjoiQ0lUQVRJT04gQ0o0IiwiZW5naW5lcyI6IkZKNDQtNEEiLCJyZWciOiJONTI1V1QiLCJmaW4iOiIyNTQiLCJzZWxjYWwiOiIiLCJoZXhjb2RlIjoiIiwiY2F0IjoiTSIsInBlciI6IkIiLCJlcXVpcCI6IlNERTJFM0ZHSFJXWFlaIiwidHJhbnNwb25kZXIiOiJMQjEiLCJwYm4iOiJBMUIyQzJEMkQzTzJPM1MyIiwiZXh0cmFybWsiOiIiLCJtYXhwYXgiOiI3Iiwid2d0dW5pdHMiOiJMQlMiLCJvZXciOiIxMDI4MCIsIm16ZnciOiIxMjUwMCIsIm10b3ciOiIxNzExMCIsIm1sdyI6IjE1NjYwIiwibWF4ZnVlbCI6IjU3NjIiLCJwYXh3Z3QiOiIxNzAiLCJkZWZhdWx0Y2kiOiIiLCJmdWVsZmFjdG9yIjoiUDAwIiwiY3J1aXNlb2Zmc2V0IjoiUDAwMDAifQ--)
+
+Check out our interim SoP doc: [Interim SoP Document](https://docs.google.com/document/d/15qb3g2ECsA8XH6gSbqbe5kGydNJ3Tj0j7vJPAWirwh4/edit?usp=sharing)
+
+---
+
+## Installation
+Installation is easy, simply copy the `workingtitle-aircraft-cj4` folder inside the zip file to your MSFS Community folder. 
+
+**Important: We recommend that you fully delete the previous `workingtitle-aircraft-cj4` folder before copying this release.**
+
+## Changes
+* Fixed SimBrief import for compatibility with 1.11.6.0
+* Fixed Mach Hold not synchronizing with mach changes
+
+## Known Issues
+* Altitude constraints are not currently selectable on the map due to incorrect data being displayed.
+* The speed constraints on arrivals may not show correctly because of database issues.
+* After using Direct-To, the navigation will not always automatically sequence to the next fix and may enter ROL mode. You can re-activate NAV to navigate to the next fix if you encounter this issue.
+* The aircraft is still using the built-in MSFS autopilot (for now). All the existing limitations of that still apply. It does behave a bit better with the various enhancements applied.
+* Some flight plan distances may still be misreported when the approach is activated. Please log an issue if you encounter this with details.
+* Some instances of the autopilot skipping approach waypoints still occur - this is deep in the sim handling of waypoints and is, for now, out of our hands. We will continue to research this.
diff --git a/src/workingtitle-aircraft-cj4/SimObjects/Airplanes/Asobo_CJ4/ai.cfg b/src/workingtitle-aircraft-cj4/SimObjects/Airplanes/Asobo_CJ4/ai.cfg
@@ -0,0 +1,27 @@
+[VERSION]
+major = 1
+minor = 0
+
+[TAKEOFF]
+
+[WAYPOINT]
+
+[LANDING]
+flareAngle = 0
+
+[SIMPLIFIEDSIM]
+
+[STICKANDRUDDER]
+rudderGroundPID = 	0.015, 0.001, 0.001, 1.0, 1.0 ; Pk,Ik,Dk,I boundary, D boundary
+throttleGroundPID = 1.0,0.10,10.0,10.0,20.0
+brakeDifferentialPID = 0.0, 0.0,0.0,0.0, 0.0
+throttleDifferentialPID = 0.0 ,0.0,0.0,0.0,0.0
+throttlePID =  21.0,0.1,20.0,15.0,100.0
+pitchPID = 2.0, 0.2,  5.0, 5.0,  100.0
+rollPID = 1.2, 0.1,  1.2, 8.0,  100.0
+headingPID = 1.5, 0.3, 2.1, 0.025, 1.0
+verticalSpeedPID = 0.1, 0.001,  0.135, 300.0,1000.0
+nav_ex1PID = 3.0, 0.01, 2.0, 0.035,  50.0
+nav_yawPID = 0.015, 0.01, 0.001, 1.0, 360
+glideSlopePID = 1.6, 0.07, 15.0, 1.0,  60.0
+flightLevelPID = 100.0, 1.0, 10.0, 100.0,  1000.0
diff --git a/...ents-cj4/html_ui/Pages/VCockpit/Instruments/Airliners/CJ4/FMC/CJ4_FMC_InitRefIndexPage.js b/...ents-cj4/html_ui/Pages/VCockpit/Instruments/Airliners/CJ4/FMC/CJ4_FMC_InitRefIndexPage.js
@@ -1245,7 +1245,7 @@ class CJ4_FMC_InitRefIndexPage {
             ["Working-Title-MSFS-Mods[white s-text]"],
             [""],
             [" VERSION[blue]"],
-            ["0.7.2[s-text white]"],
+            ["0.7.3[s-text white]"],
             [""],
             [""],
             [""],

diff --git a/...vcockpits-instruments-cj4/html_ui/Pages/VCockpit/Instruments/Airliners/CJ4/PFD/CJ4_PFD.js b/...vcockpits-instruments-cj4/html_ui/Pages/VCockpit/Instruments/Airliners/CJ4/PFD/CJ4_PFD.js
@@ -42,6 +42,8 @@ class CJ4_PFD extends BaseAirliners {
     Init() {
         super.Init();
         this.radioNav.setRADIONAVSource(NavSource.GPS);
+        this.radioNav.setRADIONAVActive(1, true);
+        this.radioNav.setRADIONAVActive(2, true);
         SimVar.SetSimVarValue("L:WT_CJ4_VAP", "knots", 0);
         SimVar.SetSimVarValue("L:WT_CJ4_PFD1_AOA", "Number", 0);
         SimVar.SetSimVarValue("L:WT_CJ4_V1_SPEED", "knots", 0);
@@ -232,7 +234,7 @@ class CJ4_PFD extends BaseAirliners {
 
                     const apOnGPS = SimVar.GetSimVarValue('GPS DRIVES NAV1', 'Bool');
                     if (!apOnGPS) {
-                        SimVar.SetSimVarValue('K:TOGGLE_GPS_DRIVES_NAV1', 'number', 0)
+                        SimVar.SetSimVarValue('K:TOGGLE_GPS_DRIVES_NAV1', 'number', 0);
                     }
 
                     this.onModeChanged();