Skip to content

Commit

Permalink
O11Y-1504: wo11y-dart tracer.trace spans don't end until the parent s…
Browse files Browse the repository at this point in the history
…pan ends

 - Minor corrections in documentation.
  • Loading branch information
Michael Yeager committed Mar 11, 2022
1 parent 38aef43 commit f482ad1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions lib/src/api/trace/nonrecording_span.dart
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,5 @@ class NonRecordingSpan implements api.Span {
api.InstrumentationLibrary get instrumentationLibrary => null;

@override
void recordException(dynamic exception, {StackTrace stackTrace}) {
return;
}
void recordException(dynamic exception, {StackTrace stackTrace}) {}
}
2 changes: 1 addition & 1 deletion lib/src/sdk/trace/tracer.dart
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class Tracer implements api.Tracer {
attributes: attributes);
}

/// Records a span of the given [name] for the given asynchronous function
/// Records a span of the given [name] for the given function
/// and marks the span as errored if an exception occurs.
@override
FutureOr<R> trace<R>(String name, FutureOr<R> Function() fn,
Expand Down

0 comments on commit f482ad1

Please sign in to comment.