Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bindings for transition / animation events #202

Merged
merged 3 commits into from
Aug 6, 2019

Conversation

aaronlademann-wf
Copy link
Collaborator

React JS added support for TransitionEvent and AnimationEvent in version 15 via facebook/react#6005, but we have no bindings for them here.

This PR adds bindings and test utils for SyntheticTransitionEvent and SyntheticAnimationEvent.

@greglittlefield-wf @kealjones-wk @joebingham-wk @sydneyjodon-wk

Copy link
Collaborator

@kealjones-wk kealjones-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1
:p should we add these to tests in test/react_test_utils_test.dart?

@kealjones-wk kealjones-wk self-requested a review August 6, 2019 15:35
Copy link
Collaborator

@kealjones-wk kealjones-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:p should we add these to tests in test/react_test_utils_test.dart?

Copy link
Collaborator

@kealjones-wk kealjones-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@kealjones-wk kealjones-wk merged commit 39494fa into master Aug 6, 2019
@greglittlefield-wf greglittlefield-wf deleted the add-ontransitionend branch November 21, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants