CPLAT-8037 Implement/Expose useReducer Hook #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # example/test/function_component_test.dart
greglittlefield-wf
changed the base branch from
CPLAT-8034-usestate-hook
to
5.2.0-wip
greglittlefield-wf
requested changes
Dec 2, 2019
lib/hooks.dart
Outdated
| /// Learn more: <https://reactjs.org/docs/hooks-reference.html#usereducer>. | ||
| class ReducerHook { | ||
| /// The first item of the pair returned by [React.userReducer]. | ||
| Map _state; |
There was a problem hiding this comment.
State/actions don't have to be maps, do they? If not, this class should use generics:
class ReducerHook<TState, TAActions> {
TState _state;
void Function(TActions ) _dispatch;
}as should the useReucer* functions
lib/hooks.dart
Outdated
| /// ``` | ||
| /// | ||
| /// Learn more: <https://reactjs.org/docs/hooks-reference.html#lazy-initialization>. | ||
| ReducerHook useReducerLazy<T>(Map Function(Map state, Map action) reducer, dynamic initialArg, Function init) => |
There was a problem hiding this comment.
Init could be typed more specifically than just Function
# Conflicts: # example/test/function_component_test.dart # lib/hooks.dart # lib/react_client/react_interop.dart # test/hooks_test.dart
aaronlademann-wf
force-pushed
the
5.3.0-wip
branch
from
b7cab0d to
d65d845
Compare
# Conflicts: # example/test/function_component_test.dart
# Conflicts: # lib/hooks.dart # lib/react_client/react_interop.dart # test/hooks_test.dart
greglittlefield-wf
approved these changes
Jan 14, 2020
| /// final state = useReducer(reducer, {'count': 0}); | ||
| /// | ||
| /// return react.Fragment({}, [ | ||
| /// state.state['count'], |
There was a problem hiding this comment.
#nit having state.state is a little confusing; I wonder if we could come up with a different name for the hook return value...
store? 😄 🤷♂ Nah, that's probably not better...
lib/hooks.dart
Outdated
| /// ``` | ||
| /// | ||
| /// Learn more: <https://reactjs.org/docs/hooks-reference.html#usereducer>. | ||
| ReducerHook<TState, TActions, TInit> useReducer<TState, TActions, TInit>( |
There was a problem hiding this comment.
#nit "Action" should be singular here, so as not to confuse it with flux
Suggested change
| ReducerHook<TState, TActions, TInit> useReducer<TState, TActions, TInit>( | |
| ReducerHook<TState, TAction, TInit> useReducer<TState, TAction, TInit>( |
Same on the next line and in the below function
|
+10 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support useReducer hook in
react-dart.Changes
ReducerHookclass.useReduceranduseReducerLazyfunctions.Please review: @kealjones-wk @aaronlademann-wf @greglittlefield-wf @joebingham-wk