Ensure forwardRef's ReactJsComponentFactoryProxy always uses List children
#269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglittlefield-wf
requested changes
Aug 3, 2020
| var ForwardRefTestComponent = forwardRef((props, ref) { | ||
| // Extra type checking since JS refs being passed through | ||
| // aren't caught by built-in type checking. | ||
| expect(ref, isA<Ref>()); |
There was a problem hiding this comment.
These expects get called in the component zone, not the test zone, so if they throw they won't fail the test or show up in the console output. I think they actually throw right now with "expect may only be called within tests", but the error is swallowed.
Can we move these expects out of the render call-stack? (e.g., by storing ref/children in closure variables or something).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While adding onto the
forwardRefAPI in OverReact, it was discovered that consumingprops.childrenin theforwardRefHOC threw a type error because the children weren't guaranteed to be a List as expected.Changes
alwaysReturnChildrenAsListflag onReactJsComponentFactoryProxyto ensure children are always wrapped in a List