Skip to content

Commit

Permalink
Fix issues stopping iOS build from working anymore
Browse files Browse the repository at this point in the history
- react native 0.59.9 introduces a fix for a bug stopping builds with xcode 11: facebook/react-native#25146
- also the recent name update needed a change to a file in the ios/ dir
- finding and fixing these issues was a *major pain*
  • Loading branch information
poltak committed Oct 7, 2019
1 parent b13c3f9 commit cf3965f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion app/ios/app/AppDelegate.m
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
{
RCTBridge *bridge = [[RCTBridge alloc] initWithDelegate:self launchOptions:launchOptions];
RCTRootView *rootView = [[RCTRootView alloc] initWithBridge:bridge
moduleName:@"app"
moduleName:@"Memex"
initialProperties:nil];

rootView.backgroundColor = [[UIColor alloc] initWithRed:1.0f green:1.0f blue:1.0f alpha:1];
Expand Down
2 changes: 1 addition & 1 deletion app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"pluralize": "^8.0.0",
"randombytes": "^2.1.0",
"react": "16.8.3",
"react-native": "0.59.8",
"react-native": "^0.59.9",
"react-native-camera": "^3.1.0",
"react-native-gesture-handler": "^1.3.0",
"react-native-knex": "^0.14.5",
Expand Down
8 changes: 4 additions & 4 deletions app/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5790,10 +5790,10 @@ react-native-tab-view@^1.2.0, react-native-tab-view@^1.4.1:
dependencies:
prop-types "^15.6.1"

react-native@0.59.8:
version "0.59.8"
resolved "https://registry.yarnpkg.com/react-native/-/react-native-0.59.8.tgz#ade4141c777c60f5ec4889d9811d0f80a9d56547"
integrity sha512-x1T+/pEXrjgdH9uDzd5doJy5aFlBqW04j7ljDKIGALchhnvdFbtXXrUZ/1PfWHMrIdZxtaDt4tkSttp662GSQA==
react-native@^0.59.9:
version "0.59.10"
resolved "https://registry.yarnpkg.com/react-native/-/react-native-0.59.10.tgz#352f381e382f93a0403be499c9e384bf51c2591c"
integrity sha512-guB9YW+pBqS1dnfZ4ntzjINopiCUAbdmshU2wMWD1W32fRczLAopi/7Q2iHKP8LTCdxuYZV3fa9Mew5PSuANAw==
dependencies:
"@babel/runtime" "^7.0.0"
"@react-native-community/cli" "^1.2.1"
Expand Down

0 comments on commit cf3965f

Please sign in to comment.