pywwt/layers.py: have add_data_layer() fallback to add_table_layer()
#201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method name `add_data_layer()` may be deprecated, but to maintain compatibility we should still actually do something. So, fall back to `add_table_layer()` when called. This fixes glue-wwt, which hasn't been updated to the new API yet.
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
+ Coverage 58.66% 58.75% +0.08%
==========================================
Files 24 24
Lines 1633 1634 +1
==========================================
+ Hits 958 960 +2
+ Misses 675 674 -1
Continue to review full report at Codecov.
|
astrofrog
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method name
add_data_layer()may be deprecated, but to maintain compatibility we should still actually do something. So, fall back toadd_table_layer()when called. This fixes glue-wwt, which hasn't been updated to the new API yet.