-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ecliptic grid color default and update to work with notebook 7.x #356
Update ecliptic grid color default and update to work with notebook 7.x #356
Conversation
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
==========================================
- Coverage 56.58% 56.51% -0.08%
==========================================
Files 25 25
Lines 2861 2870 +9
==========================================
+ Hits 1619 1622 +3
- Misses 1242 1248 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The CI failures are unrelated, and seem to be an issue with the Jupyter There's a migration guide for Notebook 7, but updating sounds like it could be a real task - maybe we should pin for now? |
Well, Notebook 7 is a pretty major update, but we don't actually use the |
So from what I can see, we're still getting errors because |
Things seemed to be working for me with |
That explicit installation inside the CI workflow is the only reference I can find to |
OK, I think I may have a solution for the next set of issues. Current build failure is a conda problem unrelated to this PR that's kicking in before the CI can test it, though; I think the problem will be resolved over the next day or so. (I think the current release of conda needs to be yanked and replaced.) |
Cool, yes, looks like this problem is dealt with now. The Linux py310 build failed with a segfault while running the test suite (!) but hopefully that is a once-in-a-blue-moon problem ... |
With all the colors getting exposed in #355, I accidentally gave the ecliptic grid the wrong starting color (maybe got it mixed up with the ecliptic color?) - it should be green, rather than blue, to match the engine. This PR fixes that.