-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow refreshing tile cache #375
Allow refreshing tile cache #375
Conversation
It looks like there's a pin in the CI ( |
@pkgw Ok, I think I have a beat on this now. So while we specify our Python version where I had linked above, the offending step is actually before that, in the setup. There we're installing According to the runner info, it's using Miniconda 24.3.0. Miniconda added support for Python 3.12 in 24.1.2. The last CI prior to that was using Miniconda 23.10.0, so no Python 3.12, and thus not surprising that we didn't see this issue. I'll admit I don't know exactly what we use |
As seen in WorldWideTelescope#375, the workaround added in WorldWideTelescope#352 may be causing problems now. I don't recall exactly what the issue was before, but we don't use brotli, so as a first step let's just get rid of the install command.
We wouldn't use Brotli(py) directly. In my own system, I see that urllib3 depends on it, though, so it probably comes in as a transitive dependency somewhere in the web stack (which makes sense, since Brotli is used as a compression format by modern web servers). I'm afraid that I don't remember exactly what was going on that inspired me to add in the install step — probably some kind of missing library or something that prevented Conda from running. I've just pushed a commit to just remove the install since it was just a workaround to begin with. |
Removing the
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #375 +/- ##
==========================================
- Coverage 56.51% 56.51% -0.01%
==========================================
Files 25 25
Lines 2870 2872 +2
==========================================
+ Hits 1622 1623 +1
- Misses 1248 1249 +1 ☔ View full report in Codecov by Sentry. |
The test that involves the To my eye, the other image changes seem to be stemming from the background map not having tiled in to its full resolution just yet. Fetching those tiles is something that should be pretty reliable. It's possible that this could be worked around by increasing the delays in the tests, to give the engine more time to load images, but it might be good to double-check that this isn't indicating that our webservices are having some kind of issue. |
…ment. Try removing new test images.
This PR exposes the cache-refreshing functionality of the research app to pywwt. We have a use case for this in CosmicDS (not urgent, but it was easy so I figured I'd get the ball rolling), but I think having the option available is generally useful. I did add a cautionary note in my docstring that this should really only be used when it's needed, though.
If we want a test, I'm not really sure what a good one would be - I don't see a straightforward way to use the image comparison method here.