ESM+webpackification of the engine code #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Carifio24 @imbasimba OK, I think we have a workable approach here. The combination of ESLint and ESBuild seems to work to help ensure that there aren't any mistakes in the code rearrangements. At the moment I've gone through and rearranged code in the |
This includes deleting some debug code from with MainView.cs.
Here, we delete the outermost pieces of `js/transpiled.js` to dedent the entire file. This breaks the build and the functionality of the code. It will take us a few commits to get things back into working order.
To move over to the new build framework, we're going to need a few extra interface points with the ScriptSharp infrastructure.
These will make it a bit more convenient for newer code to interact with the ScriptSharp type system. Eventually we'd like to drop that type system altogether, but the `ss.canCast` functionality is something that we don't want to futz with just yet.
Use ES6 imports and exports, building on our typesystem helpers.
Things should be functional again. The big win here is that now we can gradually break `transpiled.js` into separate source files, using `import` and `export` statements to modularize the code.
…mation It turns out that we have to get a lot of stuff into place for `astrocalc/elliptical.js` to work, but it's all pretty mechanical.
…e wrong Selection type
The `#version` command, if present, needs to be on the first line of the shader program, so our previous formatting wasn't fully working.
pkgw
force-pushed
the
engine-webpack
branch
from
2263ae2 to
1a56bf8
Compare
pkgw
changed the title
|
I have tested as much downstream functionality as I could (web client, pywwt, apps) and I believe this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request builds on #261. It switches the engine module to build with Webpack, allowing us to more conveniently break the code into individual files using ES6 imports and exports (while compiling down to code that's compatible with the ScriptSharp implementation). As a sample I've extracted one of the first modules.
This transition unfortunately involves another large batch of code churn to set things up, but the later commits in this pull request ought to be readable. (Note that, as long as #261 is unmerged, the diffs and commit list for this PR will include the ones in that PR as well.)
Also, we're not importing comments from the astrocalc C# code since it's already awkward code that was auto-translated from C++ in the Microsoft days, and these routines are about as locked-in as code can get.