engine/esm/url_helpers.js: fix HTTPS rewriting corner case #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we were given a URL like
http://mydomain.com:80/
to rewrite in force-HTTPS mode, we'd change it tohttps://mydomain.com:80/
, which obviously isn't going to work.In that one case, it makes sense to rewrite to
https://mydomain.com/
and see what happens. In cases with non-standard port specifications, that's definitely not going to work, so in those cases, we just have to keep the URL as insecure HTTP and hope the browser doesn't ding us.This change motivated by an issue in
ShowImage.aspx
, which seems to have started including the:80
in the URLs it emits in its redirects, breaking the Astrometry.Net workflow. I'm not sure why that changed, and we could try to change it back, but this modification here makes the rewriting code more correct, and should fully solve the problem. I hope.@Carifio24 Would you mind giving this a quick read-over and seeing if this seems sensible to you? I want to get this fixed quickly, but don't want to rush a dumb mistake into a release either.