Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ssoconf artifact name. #103

Merged
merged 1 commit into from
May 16, 2023

Conversation

karelmaxa
Copy link
Member

I have removed the version from the ssoconf binaries (openam-configurator-tool, openam-upgrade-tool) in the target archive. A newly built archive will have the following structure:

├── SSOConfiguratorTools-15.0.0-M3.zip
│   ├── openam-configurator-tool.jar
│   ├── openam-upgrade-tool.jar
│   ├── lib/
│   ├── ...

Old archive has the following structure:

├── SSOConfiguratorTools-15.0.0-M3.zip
│   ├── openam-configurator-tool-15.0.0-M3.jar
│   ├── openam-upgrade-tool-15.0.0-M3.jar
│   ├── lib/
│   ├── ...

The main advantage is that you can use the same artifact name when running the java -jar {ARTIFACT} command.

@karelmaxa karelmaxa requested a review from pavelhoral May 16, 2023 10:57
Copy link
Member

@pavelhoral pavelhoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice quality of life change.

@pavelhoral pavelhoral merged commit 8b296c9 into WrenSecurity:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants