-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Java 11 and 17 support #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed plugin configs are defined in wrensec-parent.
Fixes IllegalBlockSizeException in Java 17 > javax.crypto.IllegalBlockSizeException: data should be at least 16 bytes and multiples of 8
The original implementation has not been compatible with JDK > 8 because the keys must be `String`s, but they were `CaseInsensitiveKey`s.
pavelhoral
reviewed
Dec 20, 2022
openam-shared/src/main/java/org/forgerock/openam/shared/security/crypto/AESWrapEncryption.java
Show resolved
Hide resolved
I have added Jato monkey patch and the old Console pages are working now. |
pavelhoral
approved these changes
Dec 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still a lot of work left, but this makes AM work with Java 11+ so it is definitely a step in the right direction. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the build working on JDK 11 and 17 (with disabled jre8-compat profile).
List of changes:
AESWrapEncryption
- this fixesIllegalBlockSizeException
in Java 17.CaseInsensitiveProperties
to fix storing - the original implementation has not been compatible with JDK > 8 because the keys must beString
s, but they wereCaseInsensitiveKey
s.Known issues: