Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java 11 and 17 support #57

Merged
merged 9 commits into from
Dec 28, 2022

Conversation

fyrbach
Copy link
Member

@fyrbach fyrbach commented Dec 20, 2022

This PR makes the build working on JDK 11 and 17 (with disabled jre8-compat profile).

List of changes:

  • Remove useless plugin configurations that are defined in wrensec-parent (except maven-checkstyle-plugin).
  • Add and upgrade some Java 11+ related dependencies.
  • Use AESWrapPad transformation in AESWrapEncryption - this fixes IllegalBlockSizeException in Java 17.
  • Rewrite CaseInsensitiveProperties to fix storing - the original implementation has not been compatible with JDK > 8 because the keys must be Strings, but they were CaseInsensitiveKeys.
  • Fix thread pool settings
  • Add exports to Surefire options
  • Add Java 11 and 17 to GitHub Workflow build

Known issues:

  • Old GUI (data stores, agents configuration…) does not work on JDK >= 11.

Removed plugin configs are defined in wrensec-parent.
Fixes IllegalBlockSizeException in Java 17

> javax.crypto.IllegalBlockSizeException: data should be at least 16 bytes and multiples of 8
The original implementation has not been compatible with JDK > 8
because the keys must be `String`s, but they were `CaseInsensitiveKey`s.
@pavelhoral
Copy link
Member

pavelhoral commented Dec 27, 2022

I have added Jato monkey patch and the old Console pages are working now.

@pavelhoral pavelhoral marked this pull request as ready for review December 28, 2022 09:11
Copy link
Member

@pavelhoral pavelhoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a lot of work left, but this makes AM work with Java 11+ so it is definitely a step in the right direction. Thank you.

@pavelhoral pavelhoral merged commit 8d4397a into WrenSecurity:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants