Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to org.wrensecurity.wrenam groupId and cleanup POMs #73

Merged
merged 3 commits into from
Feb 1, 2023

Conversation

pavelhoral
Copy link
Member

@pavelhoral pavelhoral commented Jan 29, 2023

Performed changes:

  • uniformly formatted all POMs (basic order of elements, indentation, newlines)
  • switched groupId to org.wrensecurity.wrenam (this was the main goal)
  • renamed parent artifactId from openam to wrenam-project
  • switched to the latest wrensec-parent (changing versions of managed Maven plugins)
  • switched to the latest wrensec-commons (changing versions of managed dependencies)
  • switched to wrensec-guava (changing shaded package name)
  • changed version to 15.0.0-SNAPSHOT to mark full Wren Security transition
  • dropped unnecessary THIRD-PARTY.properties files that tracked licenses for dependencies
  • dropped unnecessary Maven profiles (connected with former's vendor publishing pipeline and OEM packaging)
  • fixed build number injection and switched to reproducible timestamp stored in top-level POM
  • updated product name in configurator messages

Additional comments:

  • I had to keep Mockito dependency at an older version because the latest one is not compatible with PowerMock. And even though I am not a big fan of PowerMock, it is here to stay - there are a lot of components that wouldn't be testable without it.
  • I have removed almost all modules from dependencyManagement section of the parent POM and left only the most shared ones. This was done to make the parent POM simpler - if we want to have a proper BOM, we might want to create proper dedicated BOM module in the future.

@pavelhoral pavelhoral added the wip Work in progress: do not merge label Jan 29, 2023
@pavelhoral pavelhoral removed the wip Work in progress: do not merge label Jan 30, 2023
Copy link
Member

@fyrbach fyrbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fyrbach fyrbach merged commit e395297 into WrenSecurity:main Feb 1, 2023
@fyrbach fyrbach deleted the feature/pom-cleanup branch February 1, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants