Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Add test for non existing groovy version #6

Merged
merged 4 commits into from
Feb 14, 2023

Conversation

WtfJoke
Copy link
Owner

@WtfJoke WtfJoke commented Feb 14, 2023

No description provided.

Both downloadTool and extractZip throw an error or do return a path
and therefore cant be undefined (as their types shows as well)
When calling getFileName the version matches already a semver version.
This means we can safely use it
to compare it directly to the FIRST_APACHE_GROOVY_VERSION
@sonarcloud
Copy link

sonarcloud bot commented Feb 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@WtfJoke WtfJoke merged commit bf552e3 into main Feb 14, 2023
@WtfJoke WtfJoke deleted the addTestsForNonFoundErrors branch February 14, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant