Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support #[derive(QueryableByName)] #97

Closed
jjangga0214 opened this issue Oct 17, 2023 · 2 comments · Fixed by #108 or #121
Closed

feat: support #[derive(QueryableByName)] #97

jjangga0214 opened this issue Oct 17, 2023 · 2 comments · Fixed by #108 or #121

Comments

@jjangga0214
Copy link

Hi!

I'd like to suggest to support QueryableByName derive.

This is useful for using sql_query.

How do you think?

@hasezoey
Copy link
Collaborator

to my understanding this derive needs to be added to the Read Struct (not Update or Create) and can be applied to all Read Structs (no special conditions, like Associations needs foreign_keys?)

@Wulf
Copy link
Owner

Wulf commented Oct 28, 2023

@jjangga0214 thanks for the suggestion and I agree @hasezoey, this is something we'd add to the Read struct. I don't see any harm in adding this. We should feature-gate this as it might increase compilation times, but have it included as part of the default feature set?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants