Add --no-crud option to skip generating CRUD functions #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyMichaelTDM
suggested changes
May 29, 2023
AnthonyMichaelTDM
suggested changes
May 29, 2023
In certain cases it might be not desireable to write CRUD functions by hand. To avoid conflict this change adds the option to skip generating those functions. This for example is a workaround for MySQL which currently is not supported by the generated functions or to support unsigned integers in id fields. Related: Wulf#46 Related: Wulf#47
longsleep
force-pushed
the
longsleep-optional-functions
branch
from
8e8b9e9 to
55fc2e7
Compare
|
This PR also was rebased on latest main. While at it, I also added a test. |
hasezoey
reviewed
Aug 31, 2023
hasezoey
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Looks good to me.
just for reference, re #56, this option would be similar to fork's --no-impls
|
@longsleep thanks for this and for your patience. Thanks for the reviews @AnthonyMichaelTDM @hasezoey 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases it might be not desireable to write CRUD functions by hand. To avoid conflict this change adds the option to skip generating those functions. This for example is a workaround for MySQL which currently is not supported by the generated functions or to support unsigned integers in id fields.
Related: #46
Related: #47