Add --readonly-* options
#88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wulf
approved these changes
Oct 28, 2023
| table.set_read_only(true); | ||
| } | ||
|
|
||
| table |
There was a problem hiding this comment.
I think we should have a computation step in the beginning of lib.rs#generate_files() that does some of these pre-generation computations, including aplying the default table options.
Going to create a new issue for this
thereby reduces amount of new-lines
to set tables to only generate StructType::Read re Wulf#56
"Int" is not a proper sql type without a number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the options
--readonly-prefixand--readonly-suffixesto set a table to be read-only. Read-only means to only generateStructType::Read(not Update or Create) and the corresponding functions.This is useful for things like SQLite's Views which are read-only (can be read, but cannot be written to)
This PR also includes a slight refactor of the
generate_for_tablefunction, which now only adds new-lines and struct if they actually have code, resulting in less empty new-lines (which is more apparent with readonly set)re #56
--read-only-prefix