rs/fix unknown markers #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rbnswartz
commented
Jan 17, 2024
rbnswartz
commented
- Improve the functionality of IgnoreUnknown
- Fix tests
PurpleGuitar
approved these changes
Jan 18, 2024
| // If this is an unkown marker and we're in Ignore Unkown Marker mode then don't add the marker. We still keep any remaining text though | ||
| if (!(result.marker is UnknownMarker) || !IgnoreUnknownMarkers) | ||
| // If this is an unknown marker and we're in Ignore Unknown Marker mode then don't add the marker. We still keep any remaining text though | ||
| if (result.marker is UnknownMarker unknownMarker) |
There was a problem hiding this comment.
That's a really convenient way to cast result.marker to UnknownMarker.
There was a problem hiding this comment.
Yeah the pattern matching and casting is really convenient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.