Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output not correctly produced #64

Closed
dennis-wey opened this issue Dec 19, 2022 · 4 comments
Closed

Output not correctly produced #64

dennis-wey opened this issue Dec 19, 2022 · 4 comments

Comments

@dennis-wey
Copy link

It seems like with version 1.2 the output broke:

Action to reproduce:

name: tests

on:
  push:
    branches: [ main ]
  pull_request:
    branches: [ main ]

jobs:
  tests:
    runs-on: ubuntu-latest
    name: Run tests

    steps:
      - name: 'Get next minor version'
        id: semvers
        uses: "WyriHaximus/github-action-next-semvers@v1"
        with:
          version: v1.1.1

      - name: Print Output
        run: |
          echo "${{ steps.semvers.outputs.v_patch }}"
          echo "${{ steps.semvers.outputs.patch }}"
          echo "${{ steps.semvers.outputs.v_minor }}"
          echo "${{ steps.semvers.outputs.minor }}"
          echo "${{ steps.semvers.outputs.major }}"
          echo "${{ steps.semvers.outputs.v_major }}"
          echo "${{ toJSON(steps.semvers.outputs) }}"

Output I'm getting:

Screenshot 2022-12-19 at 13 35 39

It seems to me like some quotes weren't correctly escaped while writing the output.

@WyriHaximus
Copy link
Owner

Having a look, thanks for reporting 👍

WyriHaximus added a commit that referenced this issue Dec 19, 2022
Output taken from https://github
.com//issues/64#issue-1502880189
by @dennis-wey
WyriHaximus added a commit that referenced this issue Dec 19, 2022
@WyriHaximus
Copy link
Owner

Just released v1.2.1, pushing v1.2.2 later today with some workflow fixes 😅 .

@dennis-wey
Copy link
Author

Thanks for the quick fix 😃

@WyriHaximus
Copy link
Owner

Glad to hear that, thanks for the update 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants